Feature/signing algorithms #67
Merged
+26
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix github action build fail due to:
Feature/force binary
Extending Partner with Signature Algo and pass the setting to signing function.
|
This is first PR of series. Will add next ones when this on is merged. |
| @@ -28,3 +28,7 @@ | |||
| "aes_192_cbc", | |||
| "aes_256_cbc", | |||
| ) | |||
| SIGNATUR_ALGORITHMS = ( | |||
| "rsassa_pkcs1v15", | |||
There was a problem hiding this comment.
did the original issue not want support for non rsa algos?
There was a problem hiding this comment.
Indeed, but the ticket has actually two parts, I only tackled the part that signature algo cannot be passed down, because it is missed in the partner object.
I miss the information about which other algos we should implement. I do think we can keep ticket as such open and ask that question and make another feature.
There was a problem hiding this comment.
@abhishek-ram : good to go or ?
abhishek-ram
approved these changes
May 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#60